/* Copyright 2018 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package serviceaccount import ( "context" "encoding/json" "fmt" "testing" "time" "gopkg.in/square/go-jose.v2/jwt" v1 "k8s.io/api/core/v1" apierrors "k8s.io/apimachinery/pkg/api/errors" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/runtime/schema" utilfeature "k8s.io/apiserver/pkg/util/feature" featuregatetesting "k8s.io/component-base/featuregate/testing" "k8s.io/kubernetes/pkg/apis/core" "k8s.io/kubernetes/pkg/features" ) func init() { now = func() time.Time { // epoch time: 1514764800 return time.Date(2018, time.January, 1, 0, 0, 0, 0, time.UTC) } newUUID = func() string { // always return a fixed/static UUID for testing return "fixed" } } func TestClaims(t *testing.T) { sa := core.ServiceAccount{ ObjectMeta: metav1.ObjectMeta{ Namespace: "myns", Name: "mysvcacct", UID: "mysvcacct-uid", }, } pod := &core.Pod{ ObjectMeta: metav1.ObjectMeta{ Namespace: "myns", Name: "mypod", UID: "mypod-uid", }, } sec := &core.Secret{ ObjectMeta: metav1.ObjectMeta{ Namespace: "myns", Name: "mysecret", UID: "mysecret-uid", }, } node := &core.Node{ ObjectMeta: metav1.ObjectMeta{ Name: "mynode", UID: "mynode-uid", }, } cs := []struct { // input sa core.ServiceAccount pod *core.Pod sec *core.Secret node *core.Node exp int64 warnafter int64 aud []string err string // desired sc *jwt.Claims pc *privateClaims featureJTI, featurePodNodeInfo, featureNodeBinding bool }{ { // pod and secret sa: sa, pod: pod, sec: sec, // really fast exp: 0, // nil audience aud: nil, err: "internal error, token can only be bound to one object type", }, { // pod sa: sa, pod: pod, // empty audience aud: []string{}, exp: 100, sc: &jwt.Claims{ Subject: "system:serviceaccount:myns:mysvcacct", IssuedAt: jwt.NewNumericDate(time.Unix(1514764800, 0)), NotBefore: jwt.NewNumericDate(time.Unix(1514764800, 0)), Expiry: jwt.NewNumericDate(time.Unix(1514764800+100, 0)), }, pc: &privateClaims{ Kubernetes: kubernetes{ Namespace: "myns", Svcacct: ref{Name: "mysvcacct", UID: "mysvcacct-uid"}, Pod: &ref{Name: "mypod", UID: "mypod-uid"}, }, }, }, { // secret sa: sa, sec: sec, exp: 100, // single member audience aud: []string{"1"}, sc: &jwt.Claims{ Subject: "system:serviceaccount:myns:mysvcacct", Audience: []string{"1"}, IssuedAt: jwt.NewNumericDate(time.Unix(1514764800, 0)), NotBefore: jwt.NewNumericDate(time.Unix(1514764800, 0)), Expiry: jwt.NewNumericDate(time.Unix(1514764800+100, 0)), }, pc: &privateClaims{ Kubernetes: kubernetes{ Namespace: "myns", Svcacct: ref{Name: "mysvcacct", UID: "mysvcacct-uid"}, Secret: &ref{Name: "mysecret", UID: "mysecret-uid"}, }, }, }, { // no obj binding sa: sa, exp: 100, // multimember audience aud: []string{"1", "2"}, sc: &jwt.Claims{ Subject: "system:serviceaccount:myns:mysvcacct", Audience: []string{"1", "2"}, IssuedAt: jwt.NewNumericDate(time.Unix(1514764800, 0)), NotBefore: jwt.NewNumericDate(time.Unix(1514764800, 0)), Expiry: jwt.NewNumericDate(time.Unix(1514764800+100, 0)), }, pc: &privateClaims{ Kubernetes: kubernetes{ Namespace: "myns", Svcacct: ref{Name: "mysvcacct", UID: "mysvcacct-uid"}, }, }, }, { // warn after provided sa: sa, pod: pod, exp: 60 * 60 * 24, warnafter: 60 * 60, // nil audience aud: nil, sc: &jwt.Claims{ Subject: "system:serviceaccount:myns:mysvcacct", IssuedAt: jwt.NewNumericDate(time.Unix(1514764800, 0)), NotBefore: jwt.NewNumericDate(time.Unix(1514764800, 0)), Expiry: jwt.NewNumericDate(time.Unix(1514764800+60*60*24, 0)), }, pc: &privateClaims{ Kubernetes: kubernetes{ Namespace: "myns", Svcacct: ref{Name: "mysvcacct", UID: "mysvcacct-uid"}, Pod: &ref{Name: "mypod", UID: "mypod-uid"}, WarnAfter: jwt.NewNumericDate(time.Unix(1514764800+60*60, 0)), }, }, }, { // node with feature gate disabled sa: sa, node: node, // really fast exp: 0, // nil audience aud: nil, err: "token bound to Node object requested, but \"ServiceAccountTokenNodeBinding\" feature gate is disabled", }, { // node & pod with feature gate disabled sa: sa, node: node, pod: pod, // really fast exp: 0, // nil audience aud: nil, sc: &jwt.Claims{ Subject: "system:serviceaccount:myns:mysvcacct", IssuedAt: jwt.NewNumericDate(time.Unix(1514764800, 0)), NotBefore: jwt.NewNumericDate(time.Unix(1514764800, 0)), Expiry: jwt.NewNumericDate(time.Unix(1514764800, 0)), }, pc: &privateClaims{ Kubernetes: kubernetes{ Namespace: "myns", Pod: &ref{Name: "mypod", UID: "mypod-uid"}, Svcacct: ref{Name: "mysvcacct", UID: "mysvcacct-uid"}, }, }, }, { // node alone sa: sa, node: node, // enable node binding feature featureNodeBinding: true, // really fast exp: 0, // nil audience aud: nil, sc: &jwt.Claims{ Subject: "system:serviceaccount:myns:mysvcacct", IssuedAt: jwt.NewNumericDate(time.Unix(1514764800, 0)), NotBefore: jwt.NewNumericDate(time.Unix(1514764800, 0)), Expiry: jwt.NewNumericDate(time.Unix(1514764800, 0)), }, pc: &privateClaims{ Kubernetes: kubernetes{ Namespace: "myns", Svcacct: ref{Name: "mysvcacct", UID: "mysvcacct-uid"}, Node: &ref{Name: "mynode", UID: "mynode-uid"}, }, }, }, { // node and pod sa: sa, pod: pod, node: node, // enable embedding pod node info feature featurePodNodeInfo: true, // really fast exp: 0, // nil audience aud: nil, sc: &jwt.Claims{ Subject: "system:serviceaccount:myns:mysvcacct", IssuedAt: jwt.NewNumericDate(time.Unix(1514764800, 0)), NotBefore: jwt.NewNumericDate(time.Unix(1514764800, 0)), Expiry: jwt.NewNumericDate(time.Unix(1514764800, 0)), }, pc: &privateClaims{ Kubernetes: kubernetes{ Namespace: "myns", Svcacct: ref{Name: "mysvcacct", UID: "mysvcacct-uid"}, Pod: &ref{Name: "mypod", UID: "mypod-uid"}, Node: &ref{Name: "mynode", UID: "mynode-uid"}, }, }, }, { // node and secret should error sa: sa, sec: sec, node: node, // enable embedding node info feature featureNodeBinding: true, // really fast exp: 0, // nil audience aud: nil, err: "internal error, token can only be bound to one object type", }, { // ensure JTI is set sa: sa, // enable setting JTI feature featureJTI: true, // really fast exp: 0, // nil audience aud: nil, sc: &jwt.Claims{ Subject: "system:serviceaccount:myns:mysvcacct", IssuedAt: jwt.NewNumericDate(time.Unix(1514764800, 0)), NotBefore: jwt.NewNumericDate(time.Unix(1514764800, 0)), Expiry: jwt.NewNumericDate(time.Unix(1514764800, 0)), ID: "fixed", }, pc: &privateClaims{ Kubernetes: kubernetes{ Namespace: "myns", Svcacct: ref{Name: "mysvcacct", UID: "mysvcacct-uid"}, }, }, }, { // ensure it fails if node binding gate is disabled sa: sa, node: node, featureNodeBinding: false, // really fast exp: 0, // nil audience aud: nil, err: "token bound to Node object requested, but \"ServiceAccountTokenNodeBinding\" feature gate is disabled", }, } for i, c := range cs { t.Run(fmt.Sprintf("case %d", i), func(t *testing.T) { // comparing json spews has the benefit over // reflect.DeepEqual that we are also asserting that // claims structs are json serializable spew := func(obj interface{}) string { b, err := json.Marshal(obj) if err != nil { t.Fatalf("err, couldn't marshal claims: %v", err) } return string(b) } // set feature flags for the duration of the test case defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.ServiceAccountTokenJTI, c.featureJTI)() defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.ServiceAccountTokenNodeBinding, c.featureNodeBinding)() defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.ServiceAccountTokenPodNodeInfo, c.featurePodNodeInfo)() sc, pc, err := Claims(c.sa, c.pod, c.sec, c.node, c.exp, c.warnafter, c.aud) if err != nil && err.Error() != c.err { t.Errorf("expected error %q but got: %v", c.err, err) } if err == nil && c.err != "" { t.Errorf("expected an error but got none") } if spew(sc) != spew(c.sc) { t.Errorf("standard claims differed\n\tsaw:\t%s\n\twant:\t%s", spew(sc), spew(c.sc)) } if spew(pc) != spew(c.pc) { t.Errorf("private claims differed\n\tsaw: %s\n\twant: %s", spew(pc), spew(c.pc)) } }) } } type deletionTestCase struct { name string time *metav1.Time expectErr bool } type claimTestCase struct { name string getter ServiceAccountTokenGetter private *privateClaims expiry jwt.NumericDate notBefore jwt.NumericDate expectErr string featureNodeBindingValidation bool } func TestValidatePrivateClaims(t *testing.T) { var ( nowUnix = int64(1514764800) serviceAccount = &v1.ServiceAccount{ObjectMeta: metav1.ObjectMeta{Name: "saname", Namespace: "ns", UID: "sauid"}} secret = &v1.Secret{ObjectMeta: metav1.ObjectMeta{Name: "secretname", Namespace: "ns", UID: "secretuid"}} pod = &v1.Pod{ObjectMeta: metav1.ObjectMeta{Name: "podname", Namespace: "ns", UID: "poduid"}} node = &v1.Node{ObjectMeta: metav1.ObjectMeta{Name: "nodename", UID: "nodeuid"}} ) deletionTestCases := []deletionTestCase{ { name: "valid", time: nil, }, { name: "deleted now", time: &metav1.Time{Time: time.Unix(nowUnix, 0)}, }, { name: "deleted near past", time: &metav1.Time{Time: time.Unix(nowUnix-1, 0)}, }, { name: "deleted near future", time: &metav1.Time{Time: time.Unix(nowUnix+1, 0)}, }, { name: "deleted now-leeway", time: &metav1.Time{Time: time.Unix(nowUnix-60, 0)}, }, { name: "deleted now-leeway-1", time: &metav1.Time{Time: time.Unix(nowUnix-61, 0)}, expectErr: true, }, } testcases := []claimTestCase{ { name: "good", getter: fakeGetter{serviceAccount, nil, nil, nil}, private: &privateClaims{Kubernetes: kubernetes{Svcacct: ref{Name: "saname", UID: "sauid"}, Namespace: "ns"}}, expectErr: "", }, { name: "expired", getter: fakeGetter{serviceAccount, nil, nil, nil}, private: &privateClaims{Kubernetes: kubernetes{Svcacct: ref{Name: "saname", UID: "sauid"}, Namespace: "ns"}}, expiry: *jwt.NewNumericDate(now().Add(-1_000 * time.Hour)), expectErr: "service account token has expired", }, { name: "not yet valid", getter: fakeGetter{serviceAccount, nil, nil, nil}, private: &privateClaims{Kubernetes: kubernetes{Svcacct: ref{Name: "saname", UID: "sauid"}, Namespace: "ns"}}, notBefore: *jwt.NewNumericDate(now().Add(1_000 * time.Hour)), expectErr: "service account token is not valid yet", }, { name: "missing serviceaccount", getter: fakeGetter{nil, nil, nil, nil}, private: &privateClaims{Kubernetes: kubernetes{Svcacct: ref{Name: "saname", UID: "sauid"}, Namespace: "ns"}}, expectErr: `serviceaccounts "saname" not found`, }, { name: "missing secret", getter: fakeGetter{serviceAccount, nil, nil, nil}, private: &privateClaims{Kubernetes: kubernetes{Svcacct: ref{Name: "saname", UID: "sauid"}, Secret: &ref{Name: "secretname", UID: "secretuid"}, Namespace: "ns"}}, expectErr: "service account token has been invalidated", }, { name: "missing pod", getter: fakeGetter{serviceAccount, nil, nil, nil}, private: &privateClaims{Kubernetes: kubernetes{Svcacct: ref{Name: "saname", UID: "sauid"}, Pod: &ref{Name: "podname", UID: "poduid"}, Namespace: "ns"}}, expectErr: "service account token has been invalidated", }, { name: "missing node", getter: fakeGetter{serviceAccount, nil, nil, nil}, private: &privateClaims{Kubernetes: kubernetes{Svcacct: ref{Name: "saname", UID: "sauid"}, Node: &ref{Name: "nodename", UID: "nodeuid"}, Namespace: "ns"}}, expectErr: "service account token has been invalidated", featureNodeBindingValidation: true, }, { name: "different uid serviceaccount", getter: fakeGetter{serviceAccount, nil, nil, nil}, private: &privateClaims{Kubernetes: kubernetes{Svcacct: ref{Name: "saname", UID: "sauidold"}, Namespace: "ns"}}, expectErr: "service account UID (sauid) does not match claim (sauidold)", }, { name: "different uid secret", getter: fakeGetter{serviceAccount, secret, nil, nil}, private: &privateClaims{Kubernetes: kubernetes{Svcacct: ref{Name: "saname", UID: "sauid"}, Secret: &ref{Name: "secretname", UID: "secretuidold"}, Namespace: "ns"}}, expectErr: "secret UID (secretuid) does not match service account secret ref claim (secretuidold)", }, { name: "different uid pod", getter: fakeGetter{serviceAccount, nil, pod, nil}, private: &privateClaims{Kubernetes: kubernetes{Svcacct: ref{Name: "saname", UID: "sauid"}, Pod: &ref{Name: "podname", UID: "poduidold"}, Namespace: "ns"}}, expectErr: "pod UID (poduid) does not match service account pod ref claim (poduidold)", }, } for _, deletionTestCase := range deletionTestCases { var ( deletedServiceAccount = serviceAccount.DeepCopy() deletedPod = pod.DeepCopy() deletedSecret = secret.DeepCopy() deletedNode = node.DeepCopy() ) deletedServiceAccount.DeletionTimestamp = deletionTestCase.time deletedPod.DeletionTimestamp = deletionTestCase.time deletedSecret.DeletionTimestamp = deletionTestCase.time deletedNode.DeletionTimestamp = deletionTestCase.time var saDeletedErr, deletedErr string if deletionTestCase.expectErr { saDeletedErr = "service account ns/saname has been deleted" deletedErr = "service account token has been invalidated" } testcases = append(testcases, claimTestCase{ name: deletionTestCase.name + " serviceaccount", getter: fakeGetter{deletedServiceAccount, nil, nil, nil}, private: &privateClaims{Kubernetes: kubernetes{Svcacct: ref{Name: "saname", UID: "sauid"}, Namespace: "ns"}}, expectErr: saDeletedErr, }, claimTestCase{ name: deletionTestCase.name + " secret", getter: fakeGetter{serviceAccount, deletedSecret, nil, nil}, private: &privateClaims{Kubernetes: kubernetes{Svcacct: ref{Name: "saname", UID: "sauid"}, Secret: &ref{Name: "secretname", UID: "secretuid"}, Namespace: "ns"}}, expectErr: deletedErr, }, claimTestCase{ name: deletionTestCase.name + " pod", getter: fakeGetter{serviceAccount, nil, deletedPod, nil}, private: &privateClaims{Kubernetes: kubernetes{Svcacct: ref{Name: "saname", UID: "sauid"}, Pod: &ref{Name: "podname", UID: "poduid"}, Namespace: "ns"}}, expectErr: deletedErr, }, claimTestCase{ name: deletionTestCase.name + " node", getter: fakeGetter{serviceAccount, nil, nil, deletedNode}, private: &privateClaims{Kubernetes: kubernetes{Svcacct: ref{Name: "saname", UID: "sauid"}, Node: &ref{Name: "nodename", UID: "nodeuid"}, Namespace: "ns"}}, expectErr: deletedErr, featureNodeBindingValidation: true, }, ) } for _, tc := range testcases { t.Run(tc.name, func(t *testing.T) { v := &validator{getter: tc.getter} expiry := jwt.NumericDate(nowUnix) if tc.expiry != 0 { expiry = tc.expiry } defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.ServiceAccountTokenNodeBindingValidation, tc.featureNodeBindingValidation)() _, err := v.Validate(context.Background(), "", &jwt.Claims{Expiry: &expiry, NotBefore: &tc.notBefore}, tc.private) if len(tc.expectErr) > 0 { if errStr := errString(err); tc.expectErr != errStr { t.Fatalf("expected error %q but got %q", tc.expectErr, errStr) } } else if err != nil { t.Fatalf("unexpected error: %v", err) } }) } } func errString(err error) string { if err == nil { return "" } return err.Error() } type fakeGetter struct { serviceAccount *v1.ServiceAccount secret *v1.Secret pod *v1.Pod node *v1.Node } func (f fakeGetter) GetServiceAccount(namespace, name string) (*v1.ServiceAccount, error) { if f.serviceAccount == nil { return nil, apierrors.NewNotFound(schema.GroupResource{Group: "", Resource: "serviceaccounts"}, name) } return f.serviceAccount, nil } func (f fakeGetter) GetPod(namespace, name string) (*v1.Pod, error) { if f.pod == nil { return nil, apierrors.NewNotFound(schema.GroupResource{Group: "", Resource: "pods"}, name) } return f.pod, nil } func (f fakeGetter) GetSecret(namespace, name string) (*v1.Secret, error) { if f.secret == nil { return nil, apierrors.NewNotFound(schema.GroupResource{Group: "", Resource: "secrets"}, name) } return f.secret, nil } func (f fakeGetter) GetNode(name string) (*v1.Node, error) { if f.node == nil { return nil, apierrors.NewNotFound(schema.GroupResource{Group: "", Resource: "nodes"}, name) } return f.node, nil }