/* Copyright 2020 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package devicemanager import ( "encoding/json" "testing" "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" "k8s.io/apimachinery/pkg/util/sets" utilfeature "k8s.io/apiserver/pkg/util/feature" featuregatetesting "k8s.io/component-base/featuregate/testing" pluginapi "k8s.io/kubelet/pkg/apis/deviceplugin/v1beta1" "k8s.io/kubernetes/pkg/features" "k8s.io/kubernetes/pkg/kubelet/cm/devicemanager/checkpoint" kubecontainer "k8s.io/kubernetes/pkg/kubelet/container" ) func TestGetContainerDevices(t *testing.T) { podDevices := newPodDevices() resourceName1 := "domain1.com/resource1" podID := "pod1" contID := "con1" devices := checkpoint.DevicesPerNUMA{0: []string{"dev1"}, 1: []string{"dev1"}} podDevices.insert(podID, contID, resourceName1, devices, newContainerAllocateResponse( withDevices(map[string]string{"/dev/r1dev1": "/dev/r1dev1", "/dev/r1dev2": "/dev/r1dev2"}), withMounts(map[string]string{"/home/r1lib1": "/usr/r1lib1"}), ), ) resContDevices := podDevices.getContainerDevices(podID, contID) contDevices, ok := resContDevices[resourceName1] require.True(t, ok, "resource %q not present", resourceName1) for devID, plugInfo := range contDevices { nodes := plugInfo.GetTopology().GetNodes() require.Equal(t, len(nodes), len(devices), "Incorrect container devices: %v - %v (nodes %v)", devices, contDevices, nodes) for _, node := range plugInfo.GetTopology().GetNodes() { dev, ok := devices[node.ID] require.True(t, ok, "NUMA id %v doesn't exist in result", node.ID) require.Equal(t, devID, dev[0], "Can't find device %s in result", dev[0]) } } } func TestResourceDeviceInstanceFilter(t *testing.T) { var expected string var cond map[string]sets.Set[string] var resp ResourceDeviceInstances devs := ResourceDeviceInstances{ "foo": DeviceInstances{ "dev-foo1": pluginapi.Device{ ID: "foo1", }, "dev-foo2": pluginapi.Device{ ID: "foo2", }, "dev-foo3": pluginapi.Device{ ID: "foo3", }, }, "bar": DeviceInstances{ "dev-bar1": pluginapi.Device{ ID: "bar1", }, "dev-bar2": pluginapi.Device{ ID: "bar2", }, "dev-bar3": pluginapi.Device{ ID: "bar3", }, }, "baz": DeviceInstances{ "dev-baz1": pluginapi.Device{ ID: "baz1", }, "dev-baz2": pluginapi.Device{ ID: "baz2", }, "dev-baz3": pluginapi.Device{ ID: "baz3", }, }, } resp = devs.Filter(map[string]sets.Set[string]{}) expected = `{}` expectResourceDeviceInstances(t, resp, expected) cond = map[string]sets.Set[string]{ "foo": sets.New[string]("dev-foo1", "dev-foo2"), "bar": sets.New[string]("dev-bar1"), } resp = devs.Filter(cond) expected = `{"bar":{"dev-bar1":{"ID":"bar1"}},"foo":{"dev-foo1":{"ID":"foo1"},"dev-foo2":{"ID":"foo2"}}}` expectResourceDeviceInstances(t, resp, expected) cond = map[string]sets.Set[string]{ "foo": sets.New[string]("dev-foo1", "dev-foo2", "dev-foo3"), "bar": sets.New[string]("dev-bar1", "dev-bar2", "dev-bar3"), "baz": sets.New[string]("dev-baz1", "dev-baz2", "dev-baz3"), } resp = devs.Filter(cond) expected = `{"bar":{"dev-bar1":{"ID":"bar1"},"dev-bar2":{"ID":"bar2"},"dev-bar3":{"ID":"bar3"}},"baz":{"dev-baz1":{"ID":"baz1"},"dev-baz2":{"ID":"baz2"},"dev-baz3":{"ID":"baz3"}},"foo":{"dev-foo1":{"ID":"foo1"},"dev-foo2":{"ID":"foo2"},"dev-foo3":{"ID":"foo3"}}}` expectResourceDeviceInstances(t, resp, expected) cond = map[string]sets.Set[string]{ "foo": sets.New[string]("dev-foo1", "dev-foo2", "dev-foo3", "dev-foo4"), "bar": sets.New[string]("dev-bar1", "dev-bar2", "dev-bar3", "dev-bar4"), "baz": sets.New[string]("dev-baz1", "dev-baz2", "dev-baz3", "dev-bar4"), } resp = devs.Filter(cond) expected = `{"bar":{"dev-bar1":{"ID":"bar1"},"dev-bar2":{"ID":"bar2"},"dev-bar3":{"ID":"bar3"}},"baz":{"dev-baz1":{"ID":"baz1"},"dev-baz2":{"ID":"baz2"},"dev-baz3":{"ID":"baz3"}},"foo":{"dev-foo1":{"ID":"foo1"},"dev-foo2":{"ID":"foo2"},"dev-foo3":{"ID":"foo3"}}}` expectResourceDeviceInstances(t, resp, expected) cond = map[string]sets.Set[string]{ "foo": sets.New[string]("dev-foo1", "dev-foo4", "dev-foo7"), "bar": sets.New[string]("dev-bar1", "dev-bar4", "dev-bar7"), "baz": sets.New[string]("dev-baz1", "dev-baz4", "dev-baz7"), } resp = devs.Filter(cond) expected = `{"bar":{"dev-bar1":{"ID":"bar1"}},"baz":{"dev-baz1":{"ID":"baz1"}},"foo":{"dev-foo1":{"ID":"foo1"}}}` expectResourceDeviceInstances(t, resp, expected) } func expectResourceDeviceInstances(t *testing.T, resp ResourceDeviceInstances, expected string) { // per docs in https://pkg.go.dev/encoding/json#Marshal // "Map values encode as JSON objects. The map's key type must either be a string, an integer type, or // implement encoding.TextMarshaler. The map keys are sorted [...]" // so this check is expected to be stable and not flaky data, err := json.Marshal(resp) if err != nil { t.Fatalf("unexpected JSON marshalling error: %v", err) } got := string(data) if got != expected { t.Errorf("expected %q got %q", expected, got) } } func TestDeviceRunContainerOptions(t *testing.T) { const ( podUID = "pod" containerName = "container" resource1 = "example1.com/resource1" resource2 = "example2.com/resource2" ) testCases := []struct { description string gate bool responsesPerResource map[string]*pluginapi.ContainerAllocateResponse expected *DeviceRunContainerOptions }{ { description: "empty response", gate: false, responsesPerResource: map[string]*pluginapi.ContainerAllocateResponse{ resource1: newContainerAllocateResponse(), }, expected: &DeviceRunContainerOptions{}, }, { description: "cdi devices are ingored when feature gate is disabled", gate: false, responsesPerResource: map[string]*pluginapi.ContainerAllocateResponse{ resource1: newContainerAllocateResponse( withDevices(map[string]string{"/dev/r1": "/dev/r1"}), withMounts(map[string]string{"/home/lib1": "/home/lib1"}), withEnvs(map[string]string{"ENV1": "VALUE1"}), withCDIDevices("vendor1.com/class1=device1", "vendor2.com/class2=device2"), ), }, expected: &DeviceRunContainerOptions{ Devices: []kubecontainer.DeviceInfo{ {PathOnHost: "/dev/r1", PathInContainer: "/dev/r1", Permissions: "mrw"}, }, Mounts: []kubecontainer.Mount{ {Name: "/home/lib1", HostPath: "/home/lib1", ContainerPath: "/home/lib1", ReadOnly: true}, }, Envs: []kubecontainer.EnvVar{ {Name: "ENV1", Value: "VALUE1"}, }, }, }, { description: "cdi devices are handled when feature gate is enabled", gate: true, responsesPerResource: map[string]*pluginapi.ContainerAllocateResponse{ resource1: newContainerAllocateResponse( withCDIDevices("vendor1.com/class1=device1", "vendor2.com/class2=device2"), ), }, expected: &DeviceRunContainerOptions{ Annotations: []kubecontainer.Annotation{ {Name: "cdi.k8s.io/devicemanager_pod-container", Value: "vendor1.com/class1=device1,vendor2.com/class2=device2"}, }, CDIDevices: []kubecontainer.CDIDevice{ {Name: "vendor1.com/class1=device1"}, {Name: "vendor2.com/class2=device2"}, }, }, }, { description: "cdi devices from multiple resources are handled when feature gate is enabled", gate: true, responsesPerResource: map[string]*pluginapi.ContainerAllocateResponse{ resource1: newContainerAllocateResponse( withCDIDevices("vendor1.com/class1=device1", "vendor2.com/class2=device2"), ), resource2: newContainerAllocateResponse( withCDIDevices("vendor3.com/class3=device3", "vendor4.com/class4=device4"), ), }, expected: &DeviceRunContainerOptions{ Annotations: []kubecontainer.Annotation{ {Name: "cdi.k8s.io/devicemanager_pod-container", Value: "vendor1.com/class1=device1,vendor2.com/class2=device2,vendor3.com/class3=device3,vendor4.com/class4=device4"}, }, CDIDevices: []kubecontainer.CDIDevice{ {Name: "vendor1.com/class1=device1"}, {Name: "vendor2.com/class2=device2"}, {Name: "vendor3.com/class3=device3"}, {Name: "vendor4.com/class4=device4"}, }, }, }, { description: "duplicate cdi devices are skipped", gate: true, responsesPerResource: map[string]*pluginapi.ContainerAllocateResponse{ resource1: newContainerAllocateResponse( withCDIDevices("vendor1.com/class1=device1", "vendor2.com/class2=device2"), ), resource2: newContainerAllocateResponse( withCDIDevices("vendor2.com/class2=device2", "vendor3.com/class3=device3"), ), }, expected: &DeviceRunContainerOptions{ Annotations: []kubecontainer.Annotation{ {Name: "cdi.k8s.io/devicemanager_pod-container", Value: "vendor1.com/class1=device1,vendor2.com/class2=device2,vendor3.com/class3=device3"}, }, CDIDevices: []kubecontainer.CDIDevice{ {Name: "vendor1.com/class1=device1"}, {Name: "vendor2.com/class2=device2"}, {Name: "vendor3.com/class3=device3"}, }, }, }, } for _, tc := range testCases { t.Run(tc.description, func(t *testing.T) { as := assert.New(t) defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.DevicePluginCDIDevices, tc.gate)() podDevices := newPodDevices() for resourceName, response := range tc.responsesPerResource { podDevices.insert("pod", "container", resourceName, nil, response, ) } opts := podDevices.deviceRunContainerOptions(podUID, containerName) // The exact ordering of the options depends on the order of the resources in the map. // We therefore use `ElementsMatch` instead of `Equal` on the member slices. as.ElementsMatch(tc.expected.Annotations, opts.Annotations) as.ElementsMatch(tc.expected.CDIDevices, opts.CDIDevices) as.ElementsMatch(tc.expected.Devices, opts.Devices) as.ElementsMatch(tc.expected.Envs, opts.Envs) as.ElementsMatch(tc.expected.Mounts, opts.Mounts) }) } }