package apidiff import ( "fmt" "go/types" "sort" ) // Two types are correspond if they are identical except for defined types, // which must correspond. // // Two defined types correspond if they can be interchanged in the old and new APIs, // possibly after a renaming. // // This is not a pure function. If we come across named types while traversing, // we establish correspondence. func (d *differ) correspond(old, new types.Type) bool { return d.corr(old, new, nil) } // corr determines whether old and new correspond. The argument p is a list of // known interface identities, to avoid infinite recursion. // // corr calls itself recursively as much as possible, to establish more // correspondences and so check more of the API. E.g. if the new function has more // parameters than the old, compare all the old ones before returning false. // // Compare this to the implementation of go/types.Identical. func (d *differ) corr(old, new types.Type, p *ifacePair) bool { // Structure copied from types.Identical. switch old := old.(type) { case *types.Basic: if new, ok := new.(*types.Basic); ok { return old.Kind() == new.Kind() } case *types.Array: if new, ok := new.(*types.Array); ok { return d.corr(old.Elem(), new.Elem(), p) && old.Len() == new.Len() } case *types.Slice: if new, ok := new.(*types.Slice); ok { return d.corr(old.Elem(), new.Elem(), p) } case *types.Map: if new, ok := new.(*types.Map); ok { return d.corr(old.Key(), new.Key(), p) && d.corr(old.Elem(), new.Elem(), p) } case *types.Chan: if new, ok := new.(*types.Chan); ok { return d.corr(old.Elem(), new.Elem(), p) && old.Dir() == new.Dir() } case *types.Pointer: if new, ok := new.(*types.Pointer); ok { return d.corr(old.Elem(), new.Elem(), p) } case *types.Signature: if new, ok := new.(*types.Signature); ok { pe := d.corr(old.Params(), new.Params(), p) re := d.corr(old.Results(), new.Results(), p) return old.Variadic() == new.Variadic() && pe && re } case *types.Tuple: if new, ok := new.(*types.Tuple); ok { for i := 0; i < old.Len(); i++ { if i >= new.Len() || !d.corr(old.At(i).Type(), new.At(i).Type(), p) { return false } } return old.Len() == new.Len() } case *types.Struct: if new, ok := new.(*types.Struct); ok { for i := 0; i < old.NumFields(); i++ { if i >= new.NumFields() { return false } of := old.Field(i) nf := new.Field(i) if of.Anonymous() != nf.Anonymous() || old.Tag(i) != new.Tag(i) || !d.corr(of.Type(), nf.Type(), p) || !d.corrFieldNames(of, nf) { return false } } return old.NumFields() == new.NumFields() } case *types.Interface: if new, ok := new.(*types.Interface); ok { // Deal with circularity. See the comment in types.Identical. q := &ifacePair{old, new, p} for p != nil { if p.identical(q) { return true // same pair was compared before } p = p.prev } oldms := d.sortedMethods(old) newms := d.sortedMethods(new) for i, om := range oldms { if i >= len(newms) { return false } nm := newms[i] if d.methodID(om) != d.methodID(nm) || !d.corr(om.Type(), nm.Type(), q) { return false } } return old.NumMethods() == new.NumMethods() } case *types.Named: return d.establishCorrespondence(old, new) case *types.TypeParam: if new, ok := new.(*types.TypeParam); ok { if old.Index() == new.Index() { return true } } default: panic(fmt.Sprintf("unknown type kind %T", old)) } return false } // Compare old and new field names. We are determining correspondence across packages, // so just compare names, not packages. For an unexported, embedded field of named // type (non-named embedded fields are possible with aliases), we check that the type // names correspond. We check the types for correspondence before this is called, so // we've established correspondence. func (d *differ) corrFieldNames(of, nf *types.Var) bool { if of.Anonymous() && nf.Anonymous() && !of.Exported() && !nf.Exported() { if on, ok := of.Type().(*types.Named); ok { nn := nf.Type().(*types.Named) return d.establishCorrespondence(on, nn) } } return of.Name() == nf.Name() } // establishCorrespondence records and validates a correspondence between // old and new. // // If this is the first type corresponding to old, it checks that the type // declaration is compatible with old and records its correspondence. // Otherwise, it checks that new is equivalent to the previously recorded // type corresponding to old. func (d *differ) establishCorrespondence(old *types.Named, new types.Type) bool { oldname := old.Obj() // If there already is a corresponding new type for old, check that they // are the same. if c := d.correspondMap.At(old); c != nil { return types.Identical(c.(types.Type), new) } // Attempt to establish a correspondence. // Assume the types don't correspond unless they have the same // ID, or are from the old and new packages, respectively. // // This is too conservative. For instance, // [old] type A = q.B; [new] type A q.C // could be OK if in package q, B is an alias for C. // Or, using p as the name of the current old/new packages: // [old] type A = q.B; [new] type A int // could be OK if in q, // [old] type B int; [new] type B = p.A // In this case, p.A and q.B name the same type in both old and new worlds. // Note that this case doesn't imply circular package imports: it's possible // that in the old world, p imports q, but in the new, q imports p. // // However, if we didn't do something here, then we'd incorrectly allow cases // like the first one above in which q.B is not an alias for q.C // // What we should do is check that the old type, in the new world's package // of the same path, doesn't correspond to something other than the new type. // That is a bit hard, because there is no easy way to find a new package // matching an old one. switch new := new.(type) { case *types.Named: newn := new oobj := old.Obj() nobj := newn.Obj() if oobj.Pkg() != d.old || nobj.Pkg() != d.new { // Compare the fully qualified names of the types. // // TODO(jba): when comparing modules, we should only look at the // paths relative to the module path, because the module paths may differ. // See cmd/gorelease/testdata/internalcompat. var opath, npath string if oobj.Pkg() != nil { opath = oobj.Pkg().Path() } if nobj.Pkg() != nil { npath = nobj.Pkg().Path() } return oobj.Name() == nobj.Name() && opath == npath } // Two generic named types correspond if their type parameter lists correspond. // Since one or the other of those lists will be empty, it doesn't hurt // to check both. oldOrigin := old.Origin() newOrigin := newn.Origin() if oldOrigin != old { // old is an instantiated type. if newOrigin == newn { // new is not; they cannot correspond. return false } // Two instantiated types correspond if their origins correspond and // their type argument lists correspond. if !d.correspond(oldOrigin, newOrigin) { return false } if !d.typeListsCorrespond(old.TypeArgs(), newn.TypeArgs()) { return false } } else { if !d.typeParamListsCorrespond(old.TypeParams(), newn.TypeParams()) { return false } } case *types.Basic: if old.Obj().Pkg() != d.old { // A named type from a package other than old never corresponds to a basic type. return false } default: // Only named and basic types can correspond. return false } // If there is no correspondence, create one. d.correspondMap.Set(old, new) // Check that the corresponding types are compatible. d.checkCompatibleDefined(oldname, old, new) return true } func (d *differ) typeListsCorrespond(tl1, tl2 *types.TypeList) bool { if tl1.Len() != tl2.Len() { return false } for i := 0; i < tl1.Len(); i++ { if !d.correspond(tl1.At(i), tl2.At(i)) { return false } } return true } // Two list of type parameters correspond if they are the same length, and // the constraints of corresponding type parameters correspond. func (d *differ) typeParamListsCorrespond(tps1, tps2 *types.TypeParamList) bool { if tps1.Len() != tps2.Len() { return false } for i := 0; i < tps1.Len(); i++ { if !d.correspond(tps1.At(i).Constraint(), tps2.At(i).Constraint()) { return false } } return true } func (d *differ) sortedMethods(iface *types.Interface) []*types.Func { ms := make([]*types.Func, iface.NumMethods()) for i := 0; i < iface.NumMethods(); i++ { ms[i] = iface.Method(i) } sort.Slice(ms, func(i, j int) bool { return d.methodID(ms[i]) < d.methodID(ms[j]) }) return ms } func (d *differ) methodID(m *types.Func) string { // If the method belongs to one of the two packages being compared, use // just its name even if it's unexported. That lets us treat unexported names // from the old and new packages as equal. if m.Pkg() == d.old || m.Pkg() == d.new { return m.Name() } return m.Id() } // Copied from the go/types package: // An ifacePair is a node in a stack of interface type pairs compared for identity. type ifacePair struct { x, y *types.Interface prev *ifacePair } func (p *ifacePair) identical(q *ifacePair) bool { return p.x == q.x && p.y == q.y || p.x == q.y && p.y == q.x }